Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock

From: Tahsin Erdogan
Date: Mon Mar 27 2017 - 14:38:51 EST


On Sun, Mar 26, 2017 at 3:54 AM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
> Is an unlock needed before line 848? Or does blkg_lookup_check take care
> of it?

Unlock is not needed. On success, function returns with locks held.
It is documented at line 805:

"... This function returns with RCU read
* lock and queue lock held and must be paired with blkg_conf_finish()."