Re: Audit fixes for v4.11 (#1)

From: Paul Moore
Date: Mon Mar 27 2017 - 15:05:36 EST


On Sun, Mar 26, 2017 at 1:23 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Mar 26, 2017 at 8:18 AM, Paul Moore <pmoore@xxxxxxxxxx> wrote:
>> On Sat, Mar 25, 2017 at 6:23 PM, Linus Torvalds
>> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>> The whole reason for that inlined part, and the uninlined
>>> __audit_signal_info() helper was that the code *used* to be able to
>>> avoid a function call entirely. That reason is now gone.
>>
>> Agreed. Normally I would say let's just fix it in audit/next and I'll
>> send it to you during the next merge window; however, since we're
>> breaking the whole point of this inline in the -rcX stage, and the
>> uninline'ing patch would be rather trivial, would you prefer I send it
>> to you now for v4.11?
>
> It's fine if it does into some "next" branch for 4.12, I don't think
> there is any hurry as long as this gets fixed eventually.
>
> But I'll take the obvious cleanup for 4.11 too if you end up having
> other things coming my way.

Okay, sounds good. I'll work on it this week, assuming nothing blows
up in the process expect to see it later this week.

--
paul moore
security @ redhat