Re: [PATCH] netvsc: fix dereference before null check errors

[David Miller]

From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
Date: Mon, 27 Mar 2017 00:50:27 +0000

> 
> 
>> -----Original Message-----
>> From: Colin King [mailto:colin.king@xxxxxxxxxxxxx]
>> Sent: Saturday, March 25, 2017 10:27 AM
>> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
>> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
>> devel@xxxxxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx
>> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Subject: [PATCH] netvsc: fix dereference before null check errors
>> 
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> 
>> ndev is being checked to see if it is a null pointer however before
>> the null check ndev is being dereferenced; hence there is a potential
>> null pointer dereference bug that needs fixing. Fix this by only
>> dereferencing ndev after the null check.
>> 
>> Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference
>> before null check")
>> 
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>

Applied.