Re: [PATCH] sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable

From: Martin K. Petersen
Date: Mon Mar 27 2017 - 22:13:40 EST


Fam Zheng <famz@xxxxxxxxxx> writes:

Hi Fam,

> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2957,6 +2957,7 @@ static int sd_revalidate_disk(struct gendisk *disk)
> rw_max = logical_to_sectors(sdp, sdkp->opt_xfer_blocks);
> } else
> rw_max = BLK_DEF_MAX_SECTORS;
> + rw_max = min_not_zero(rw_max, dev_max);

rw_max is in sectors, dev_max is in logical blocks.

>
> /* Combine with controller limits */
> q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q));

--
Martin K. Petersen Oracle Linux Engineering