Re: [PATCH] net: mvneta: set rx mode during resume if interface is running

From: Jisheng Zhang
Date: Mon Mar 27 2017 - 22:32:49 EST


Dear David,

On Mon, 27 Mar 2017 16:15:34 -0700 David Miller wrote:

> From: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> Date: Mon, 27 Mar 2017 18:59:05 +0800
>
> > I found a bug by:
> >
> > 0. boot and start dhcp client
> > 1. echo mem > /sys/power/state
> > 2. resume back immediately
> > 3. don't touch dhcp client to renew the lease
> > 4. ping the gateway. No acks
> >
> > Usually, after step2, the DHCP lease isn't expired, so in theory we
> > should resume all back. But in fact, it doesn't. It turns out
> > the rx mode isn't resumed correctly. This patch fixes it by adding
> > mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
>
> This doesn't apply cleanly to the net tree, please respin.

This patch is generated against net-next, for mvneta suspend/resume support
is added into net-next recently. I did need to use the "[PATCH net-next]" for
the patch title, will take care in the future.

Sorry for confusion,
Jisheng