Re: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT

From: Kevin Hilman
Date: Tue Mar 28 2017 - 10:58:06 EST


Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes:

> On 03/28/2017 11:30 AM, Linus Walleij wrote:
>> On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>
>> '> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges
>>> is needed when gpiochip_add_data() is called but in the current implementation
>>> the ranges are added from the driver afterwards.
>>>
>>> A simple solution is to rely on the DR gpio-ranges attribute and remove the
>>> call to gpiochip_add_pin_range().
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>>
>> This is fine once the ranges have been applied to the device trees I guess.
>>
>> Tell me when you want me to merge this.
>>
>> Yours,
>> Linus Walleij
>>
>
> Hi Linus,
>
> Kevin should merge the DT patches since they have now Tested and Reviewed by's, so you can merge it now if you can.
> Since it will live in you pinctrl tree, it will only impact linux-next until Kevin merges them.

I've applied the DT patches now (branch: v4.12/dt64)

Kevin