Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

[Jerome Brunet]

On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote:
> Expose the clock ids for the three none AO uarts to the dt-bindings

Are they all used in the device tree ?
We try to only expose what we need in the DT
The recent discussion over CLKID_CPUCLK proved it was a sane thing to do.

> 
> Signed-off-by: Helmut Klein <hgkr.klein@xxxxxxxxx>
> ---
> Âdrivers/clk/meson/gxbb.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 6 +++---
> Âinclude/dt-bindings/clock/gxbb-clkc.h | 3 +++
> Â2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h
> index 8ee2022ce5d5..1edfaa5fe307 100644
> --- a/drivers/clk/meson/gxbb.h
> +++ b/drivers/clk/meson/gxbb.h
> @@ -194,7 +194,7 @@
> Â/* #define CLKID_SAR_ADC */
> Â#define CLKID_SMART_CARD	ÂÂ24
> Â#define CLKID_RNG0		ÂÂ25
> -#define CLKID_UART0		ÂÂ26
> +/* CLKID_UART0 */
> Â#define CLKID_SDHC		ÂÂ27
> Â#define CLKID_STREAM		ÂÂ28
> Â#define CLKID_ASYNC_FIFO	ÂÂ29
> @@ -216,7 +216,7 @@
> Â#define CLKID_ADC		ÂÂ45
> Â#define CLKID_BLKMV		ÂÂ46
> Â#define CLKID_AIU		ÂÂ47
> -#define CLKID_UART1		ÂÂ48
> +/* CLKID_UART1 */
> Â#define CLKID_G2D		ÂÂ49
> Â/* CLKID_USB0 */
> Â/* CLKID_USB1 */
> @@ -236,7 +236,7 @@
> Â/* CLKID_USB0_DDR_BRIDGE */
> Â#define CLKID_MMC_PCLK		ÂÂ66
> Â#define CLKID_DVIN		ÂÂ67
> -#define CLKID_UART2		ÂÂ68
> +/* CLKID_UART2 */
> Â/* #define CLKID_SANA */
> Â#define CLKID_VPU_INTR		ÂÂ70
> Â#define CLKID_SEC_AHB_AHB3_BRIDGE 71
> diff --git a/include/dt-bindings/clock/gxbb-clkc.h b/include/dt-
> bindings/clock/gxbb-clkc.h
> index 692846c7941b..7b329df47752 100644
> --- a/include/dt-bindings/clock/gxbb-clkc.h
> +++ b/include/dt-bindings/clock/gxbb-clkc.h
> @@ -15,13 +15,16 @@
> Â#define CLKID_SPI		34
> Â#define CLKID_I2C		22
> Â#define CLKID_SAR_ADC		23
> +#define CLKID_UART0		26
> Â#define CLKID_ETH		36
> +#define CLKID_UART1		48
> Â#define CLKID_USB0		50
> Â#define CLKID_USB1		51
> Â#define CLKID_USB		55
> Â#define CLKID_HDMI_PCLK		63
> Â#define CLKID_USB1_DDR_BRIDGE	64
> Â#define CLKID_USB0_DDR_BRIDGE	65
> +#define CLKID_UART2		68
> Â#define CLKID_SANA		69
> Â#define CLKID_GCLK_VENCI_INT0	77
> Â#define CLKID_AO_I2C		93
> --
> 2.11.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-amlogic