Re: [PATCH] mm,hugetlb: compute page_size_log properly
From: Michal Hocko
Date: Wed Mar 29 2017 - 04:06:53 EST
On Tue 28-03-17 10:54:08, Matthew Wilcox wrote:
> On Tue, Mar 28, 2017 at 09:55:13AM -0700, Davidlohr Bueso wrote:
> > Do we have any consensus here? Keeping SHM_HUGE_* is currently
> > winning 2-1. If there are in fact users out there computing the
> > value manually, then I am ok with keeping it and properly exporting
> > it. Michal?
>
> Well, let's see what it looks like to do that. I went down the rabbit
> hole trying to understand why some of the SHM_ flags had the same value
> as each other until I realised some of them were internal flags, some
> were flags to shmat() and others were flags to shmget(). Hopefully I
> disambiguated them nicely in this patch. I also added 8MB and 16GB sizes.
> Any more architectures with a pet favourite huge/giant page size we
> should add convenience defines for?
Do we actually have any users?
--
Michal Hocko
SUSE Labs