Re: [PATCH] arch:x86/boot/compressed/error: Add declaration for necessary head file

[Kees Cook]

On Wed, Mar 29, 2017 at 12:00 AM, Zhengyi Shen <shenzhengyi@xxxxxxxxx> wrote:
> Add declaration for the error.h file to correct the sparse warnings.
>
> Sparse warnings:
> arch/x86/boot/compressed/error.c:8:6:
>         warning: symbol 'warn' was not declared. Should it be static?
> arch/x86/boot/compressed/error.c:15:6:
>         warning: symbol 'error' was not declared. Should it be static?
>
> Signed-off-by: Zhengyi Shen <shenzhengyi@xxxxxxxxx>

Thanks!

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

> ---
>  arch/x86/boot/compressed/error.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/boot/compressed/error.c b/arch/x86/boot/compressed/error.c
> index 6248740..3192202 100644
> --- a/arch/x86/boot/compressed/error.c
> +++ b/arch/x86/boot/compressed/error.c
> @@ -4,6 +4,7 @@
>   * memcpy() and memmove() are defined for the compressed boot environment.
>   */
>  #include "misc.h"
> +#include "error.h"
>
>  void warn(char *m)
>  {
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security