Re: [PATCH 0/4] ftrace: Add 'function-fork' trace option (v1)
From: Namhyung Kim
Date: Wed Mar 29 2017 - 21:41:15 EST
Hi Masami,
On Thu, Mar 30, 2017 at 9:54 AM, Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> On Wed, 29 Mar 2017 10:46:21 +0900
> Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
>> Hello,
>>
>> This patchset add 'function-fork' option to function tracer which
>> makes pid filter to be inherited like 'event-fork' does. During the
>> test, I found a bug of pid filter on an instance directory. The patch
>> 1 fixes it and maybe it should go to the stable tree.
>>
>> The function-fork option is disabled by default as event-fork does,
>> but we might consider changing the default since it seems to be more
>> natural from an user's perspective IMHO.
>
> By the way, I thought that event-fork option also effected to
> function tracer. Is there any reason we should separate those?
> I mean, we can add "trace-fork" option instead of "function-fork"
> for setting both pid filters at once.
>
> Thank you,
I'm ok with combining two options.
Thanks
Namhyung