Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link()

[Amir Goldstein]

On Thu, Mar 30, 2017 at 12:03 PM, Richard Weinberger <richard@xxxxxx> wrote:
> Amir,
>
> Am 30.03.2017 um 10:59 schrieb Amir Goldstein:
>> On Thu, Mar 30, 2017 at 11:56 AM, Richard Weinberger <richard@xxxxxx> wrote:
>>> It is perfectly fine to link a tmpfile back using linkat().
>>> Since tmpfiles are created with a link count of 0 they appear
>>> on the orphan list, upon re-linking the inode has to be removed
>>> from the orphan list again.
>>>
>>
>> Looks good.
>>
>>> Cc: <stable@xxxxxxxxxxxxxxx>
>>> Cc: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
>>> Cc: Amir Goldstein <amir73il@xxxxxxxxx
>>
>> typo: missing closing >
>
> Whoops, copied one byte too few from Thunderbird. :D
> Will fix before pushing.
>


It's worth mentioning the bug that Ralph reported.
The fact that overlayfs mount in v4.11-rc causes corruption of ubifs is much
more severe than what the current commit message implies (fix of a corner case).

I would also add # v4.9 hint to stable tag, just to be nice ;-)