Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error

[Felipe Balbi]

Hi,

cristian.birsan@xxxxxxxxxxxxx writes:
> From: Cristian Birsan <cristian.birsan@xxxxxxxxxxxxx>
>
> Use dev_warn() to display EP configuration error to avoid silent failure.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@xxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2bd8410..942c9c9 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>  		 * but it's clearly harmless...
>  		 */
>  		if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
> -			dev_dbg(&udc->pdev->dev,
> +			dev_warn(&udc->pdev->dev,

seems like dev_err() would've been more fitting.

-- 
balbi

Attachment: signature.asc
Description: PGP signature