Re: [RESEND PATCH v2 1/2] mfd: retu: Add OF device ID table

[Rob Herring]

On Wed, Mar 15, 2017 at 5:49 AM, Javier Martinez Canillas
<javier@xxxxxxxxxxxxxxx> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.

It should also have the OF MODALIAS.

> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.

I believe this is already the case.

> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.

How so? These "compatible" strings are not documented, so there is no
ABI. You may have been lucky to get things working using the driver
name as the compatible string.

Rob