Re: [PATCH] serial: tegra: Map the iir register to default defines

From: Jon Hunter
Date: Thu Mar 30 2017 - 09:42:51 EST



On 29/03/17 19:48, Olliver Schinagl wrote:
> The tegra serial IP seems to be following the common layout and the
> interrupt ID's match up nicely. Replace the magic values to match the
> common serial_reg defines, with the addition of the Tegra unique End of
> Data interrupt.
>
> Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
> ---
> Note I do not own any tegra hardware and just noticed it while working on my
> somewhat related previous patch,
> "serial: Do not treat the IIR register as a bitfield"
>
> As such, this patch can only be applied after the aforementioned patch or the
> iir variable will not have its mask applied yet.

Nit-pick. If this is the case, then this should really be part of a
patch series so it is obvious to everyone that this should only be
applied after the other patch.

Cheers
Jon

--
nvpublic