Re: [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C

[Andrew Jeffery]

On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
> Sorry for the delay, I went on a long vacation prior to receiving feedback and
> got back in the middle of a hardware bring up that consumed all of my attention
> for an extended period of time. I will try to plan upstream submissions around
> my other responsibilities better in the future.
> 
> Addressed comments from:
> Â - Vladimir in: https://www.spinics.net/lists/linux-i2c/msg27387.html
> ÂÂÂÂand: https://www.spinics.net/lists/linux-i2c/msg27386.html
> Â - Wolfram in: https://www.spinics.net/lists/linux-i2c/msg27476.html
> ÂÂÂÂand: https://www.spinics.net/lists/linux-i2c/msg27483.html
> 
> Changes since previous update:
> Â - No longer arbitrarily restrict bus to be slave xor master.
> Â - Pulled out "struct aspeed_i2c_controller" as a interrupt controller.
> Â - Pulled out slave support into its own commit.
> Â - Rewrote code that sets clock divider register because the original version
> ÂÂÂÂset it incorrectly.
> Â - Discovered and fixed issue in implementation that caused certain slave
> ÂÂÂÂdevices to misbehave; the cause was that the master IRQ handler would return
> ÂÂÂÂcontrol to the requesting thread after the last RX or TX command was handled
> ÂÂÂÂsuch that the requesting thread would issue either a repeated start or stop.
> ÂÂÂÂThis was incorrect because the time taken to complete the completion was too
> ÂÂÂÂgreat. I fixed this by rewriting the master IRQ handler so that it now
> ÂÂÂÂmanages the entire transaction only returning control to the requesting
> ÂÂÂÂthread once the entire transaction is complete.
> Â - Rewrote the aspeed_i2c_master_irq handler because the old method of
> ÂÂÂÂcompleting a completion in between restarts was too slow causing devices to
> ÂÂÂÂmisbehave.
> Â - Added support for I2C_M_RECV_LEN which I had incorrectly said was supported
> ÂÂÂÂbefore.
> Â - Addressed other comments from Vladimir.
> 
> Changes have been tested on the Aspeed 2500 evaluation board, as before, and now
> on a real platform with an Aspeed 2520.

Looks like there's going to be another revision of the series, but
regardless, I've applied and tested v6 and had no issues. So:

Tested-by: Andrew Jeffery <andrew@xxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part