Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

[David Miller]

From: Salil Mehta <salil.mehta@xxxxxxxxxx>
Date: Thu, 30 Mar 2017 16:30:47 +0100

> This patch set introduces various HNS bug fixes, optimizations and code
> improvements.

There is no way you should do such an expensive calculation for every
single transmit packet as you are doing in your select_queue() routine.

That's really crazy.

Just use the networking stack's queue selection scheme, or suggest
ways to improve it.  Don't do private hashing like this in your
driver, please!