Re: [tip:WIP.x86/mm 1/1] arch/x86/kernel/process_64.c:541:35: error: '__NR_ia32_execve' undeclared
From: Thomas Gleixner
Date: Fri Mar 31 2017 - 03:25:56 EST
On Thu, 30 Mar 2017, Dmitry Safonov wrote:
> > vim +/__NR_ia32_execve +541 arch/x86/kernel/process_64.c
> >
> > 535 set_thread_flag(TIF_IA32);
> > 536 clear_thread_flag(TIF_X32);
> > 537 if (current->mm)
> > 538 current->mm->context.ia32_compat = TIF_IA32;
> > 539 current->personality |= force_personality32;
> > 540 /* Prepare the first "return" to user space */
> > > 541 task_pt_regs(current)->orig_ax = __NR_ia32_execve;
> > 542 current->thread.status |= TS_COMPAT;
> > 543 #endif
> > 544 }
>
> There was this chunk in the patch, maybe it could be done nicer,
> but I didn't find the nicer way.
> I checked it compilation/work with(out) ia32/x32/64-bit configs
> before sending.
Yeah, I know and it's just crap. WTF is wrong with:
#ifdef CONFIG_IA32_EMULATION
#include <asm/unistd_32_ia32.h>
#endif
It's not rocket science, really.
Thanks,
tglx