Re: [PATCH] HID: sony: remove redundant check for -ve err

[Benjamin Tissoires]

On Mar 27 2017 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> err is being checked for failure each time it is being updated
> so this err check is totally redundant and can be removed
> 
> Detected with CoverityScan, CID#1420665 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---

Indeed. Not sure if it will conflict with Roderick's series, but still:

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Cheers,
Benjamin

>  drivers/hid/hid-sony.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index bb124e339d26..e3c6fe554056 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -2614,9 +2614,6 @@ static int sony_input_configured(struct hid_device *hdev,
>  		ret = 0;
>  	}
>  
> -	if (ret < 0)
> -		goto err_stop;
> -
>  	if (sc->quirks & SONY_LED_SUPPORT) {
>  		ret = sony_leds_init(sc);
>  		if (ret < 0)
> -- 
> 2.11.0
>