Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public

From: Radim KrÄmÃÅ
Date: Fri Mar 31 2017 - 09:39:31 EST


2017-03-31 13:53+0200, Paolo Bonzini:
> Its value has never changed; we might as well make it part of the ABI instead
> of using the return value of KVM_CHECK_EXTENSION(KVM_CAP_COALESCED_MMIO).
>
> Because PPC does not always make MMIO available, the code has to be made
> dependent on CONFIG_KVM_MMIO rather than KVM_COALESCED_MMIO_PAGE_OFFSET.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---

I like the change to CONFIG_KVM_MMIO and the interface isn't suited for
dynamic offsets based on enabled features anyway ...

Reviewed-by: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>