Re: [PATCH 1/3] usb: pci-quirks: Add a header for SB800 I/O ports and mutex for locking

[Boszormenyi Zoltan]

2017-04-01 16:40 keltezÃssel, Alan Stern Ãrta:
> On Sat, 1 Apr 2017, Greg KH wrote:
>
> > On Sat, Apr 01, 2017 at 01:02:21PM +0200, Zoltan Boszormenyi wrote:
> > > From: Bïszïrmïnyi Zoltïn <zboszor@xxxxx>
> > >
> > > This patch adds:
> > > * a mutex in the USB PCI quirks code for synchronizing access to
> > >   the I/O ports on SB800
> > > * a new header that contains symbols for the index and data I/O ports
> > >   and wrappers for locking and unlocking the mutex.
> > > * locking around the I/O port access for SB800
> > >
> > > Signed-off-by: Zoltan Boszormenyi <zboszor@xxxxx>
> > > ---
>
> > > diff --git a/include/linux/sb800.h b/include/linux/sb800.h
> > > new file mode 100644
> > > index 0000000..5650b7d
> > > --- /dev/null
> > > +++ b/include/linux/sb800.h
> > > @@ -0,0 +1,15 @@
> > > +
> > > +#ifndef SB800_H
> > > +#define SB800_H
> > > +
> > > +#include <linux/mutex.h>
> > > +
> > > +#define SB800_PIIX4_SMB_IDX		0xcd6
> > > +#define SB800_PIIX4_SMB_DATA	0xcd7
> > > +
> > > +extern struct mutex sb800_mutex;
> > > +
> > > +#define enter_sb800()	mutex_lock(&sb800_mutex)
> > > +#define leave_sb800()	mutex_unlock(&sb800_mutex)
>
> Is include/linux/ the best place for this new header file?  Aren't
> there other locations more suitable for something that's
> board-specific?

Are there? Which subdirectory is better suited?

Would it be acceptable to not use a header at all but spell out
the "extern struct mutex..." in the two other drivers?

Thanks,
ZoltÃn BÃszÃrmÃnyi

> Alan Stern
>
> > Don't hide the mutex, just spell it out in the code itself.  No need for
> > these defines at all.
> >
> > thanks,
> >
> > greg k-h