Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation

From: Linus Walleij
Date: Sun Apr 02 2017 - 11:00:26 EST


On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 27/03/17 11:06, Andreas Klinger wrote:
>> While calculating the compensation of the humidity there are negative
>> values interpreted as unsigned because of unsigned variables used.
>> These values need to be casted to signed as indicated by the documentation
>> of the sensor.
>>
>> Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx>
>
> Looks superficially right to me, but would like an Ack from Linus Walleij.

I didn't work on these calculations, only infrastructure for the driver
but FWIW:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Matt Ranostay @Intel is the person you probably want to ACK it though,
he added the humidity calculations :)

Yours,
Linus Walleij