Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings

From: Fengguang Wu
Date: Sun Apr 02 2017 - 22:52:41 EST


Hi David,

On Sun, Apr 02, 2017 at 07:44:02PM -0700, David Miller wrote:
From: kbuild test robot <lkp@xxxxxxxxx>
Date: Sat, 1 Apr 2017 07:50:55 +0800

drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool

Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: lipeng <lipeng321@xxxxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

This doesn't apply to any of my trees.

It's a reply to Salil's patch

[PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu

and so is based on that patch.

What can the robot improve to avoid you confusing it as a general
patch for the net master trees? One possible way is to change title to

[PATCH for Salil] net: hns: fix boolreturn.cocci warnings
^^^^^^^^^^^^^^^^^

Regards,
Fengguang