Re: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload

[Daniel Vetter]

On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx> wrote:
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> index a5d83cb..5dbf011 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -246,6 +246,7 @@ static void rockchip_drm_unbind(struct device *dev)
>         rockchip_drm_fbdev_fini(drm_dev);
>         drm_kms_helper_poll_fini(drm_dev);
>
> +       drm_crtc_force_disable_all(drm_dev);

This will result in a WARN_ON in latest drm-next because rockchip is
atomic, and this helper is for legacy kms drivers. You want to use
drm_atomic_helper_shutdown here.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch