Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Icenowy Zheng]

å 2017å04æ03æ 17:15, Maxime Ripard åé:
> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
> > Allwinner H3 features a thermal sensor like the one in A33, but has its
> > register re-arranged, the clock divider moved to CCU (originally the
> > clock divider is in ADC) and added a pair of bus clock and reset.
> >
> > Update the binding document to cover H3.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> > ---
> >  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 ++++++++++++++++++++--
> >  1 file changed, 21 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> > index badff3611a98..7753133ca0ff 100644
> > --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> > +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> > @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor
> >  and sometimes as a touchscreen controller.
> >
> >  Required properties:
> > -  - compatible: "allwinner,sun8i-a33-ths",
> > +  - compatible: must contain one of the following compatibles:
> > +		- "allwinner,sun8i-a33-ths"
> > +		- "allwinner,sun8i-h3-ths"
> >    - reg: mmio address range of the chip,
> >    - #thermal-sensor-cells: shall be 0,
> >    - #io-channel-cells: shall be 0,
> >
> > -Example:
> > +Required properties for the following compatibles:
> > +		- "allwinner,sun8i-h3-ths"
> > +  - clocks: the bus clock and the input clock of the ADC,
> > +  - clock-names: should be "bus" and "ths",
>
> I guess mod instead of ths would be more consistent.

In fact I will prefer "sample" here if not "ths", as it's used
for the sampling, not like other mod clocks, which controls
all the IP block's logic.

> Maxime