Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

From: Russell King - ARM Linux
Date: Mon Apr 03 2017 - 11:16:15 EST


On Mon, Apr 03, 2017 at 09:07:43AM -0500, Rob Herring wrote:
> On Tue, Mar 28, 2017 at 05:35:52PM -0700, Steve Longerbeam wrote:
> > I assume if there's another binding doc in progress, it means
> > someone is working on another Synopsys DW CSI-2 subdevice driver.
>
> Yes. see http://patchwork.ozlabs.org/patch/736177/
>
> > Unfortunately I don't have the time to contribute and switch to
> > this other subdevice, and do test/debug.
>
> >From a DT perspective, I'm not asking that you share the subdevice
> driver, only the binding. Simply put, there's 1 h/w block here, so there
> should only be 1 binding. The binding is an ABI, so you can't just merge
> it and change it later.

I think it would be nice to have some kind of standard base binding
for CSI2 interfaces, but beyond the standard compatible/reg/interrupts
and graph properties, I'm not sure what it would look like.

As far as those properties go, the iMX6 version does better than the
DW version, because we specify the full graph, whereas the DW version
only specifies the downstream link. Once that's done, there's some
properties (like those specifying the output configuration) which
probably ought to be moved to the graph links instead, once they exist.

So, if anything, I think it's the DW version needs to be augmented with
fuller information, and some of the properties moved.

Also, as I've mentioned in my other reply, while they may both appear
to be called "Synopsys DW CSI-2" devices, they appear to be quite
different from the hardware perspective.

The rest

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.