Re: [PATCH 0/5] iommu/omap: Add support for iommu-groups and 'struct iommu_device'

[Suman Anna]

Hi Joerg,

On 03/31/2017 07:10 AM, Joerg Roedel wrote:
> Hi,
> 
> here is a small patch-set for the omap-iommu driver to make
> it use new features of the iommu-core. Please review.

Thanks for the patches - this has been on my TODO list but you beat me
in getting there first :). Are these for 4.12?

I have given the series a quick try and these currently break the
functionality. I am investigating the failures, so will mostly need some
additional changes. Let me know if you want me to take up posting of the
v2. Meanwhile, I have added some comments on the patches.

regards
Suman

> 
> Thanks,
> 
> 	Joerg
> 
> Joerg Roedel (5):
>   iommu/omap: Move data structures to omap-iommu.h
>   iommu/omap: Permanently keep iommu_dev pointer in arch_data
>   iommu/omap: Set dev->archdata.iommu = NULL in omap_iommu_remove_device
>   iommu/omap: Make use of 'struct iommu_device'
>   iommu/omap: Add iommu-group support
> 
>  drivers/iommu/omap-iommu.c               | 137 ++++++++++++++++++++-----------
>  drivers/iommu/omap-iommu.h               |  35 ++++++++
>  include/linux/platform_data/iommu-omap.h |  15 ----
>  3 files changed, 124 insertions(+), 63 deletions(-)
>