Re: [PATCH 3/6] mm: remove return value from init_currently_empty_zone

From: Reza Arbab
Date: Mon Apr 03 2017 - 17:22:46 EST


On Thu, Mar 30, 2017 at 01:54:51PM +0200, Michal Hocko wrote:
init_currently_empty_zone doesn't have any error to return yet it is
still an int and callers try to be defensive and try to handle potential
error. Remove this nonsense and simplify all callers.

Semi-related; arch_remove_memory() returns int, but callers ignore it.

Is that worth cleaning up? If so, should the implementations be simplified, or should we maybe do a pr_error() or something with it?

--
Reza Arbab