Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

From: Vivek Gautam
Date: Tue Apr 04 2017 - 00:24:12 EST




On 04/04/2017 09:44 AM, kbuild test robot wrote:
Hi Vivek,

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.11-rc5 next-20170403]
[cannot apply to pza/reset/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Vivek-Gautam/reset-APIs-to-manage-a-list-of-resets/20170404-111639
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x004-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/reset/core.c: In function 'reset_control_array_deassert':
drivers/reset/core.c:526:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
for (i = 0; i < num_rsts; i++)
^~~
drivers/reset/core.c:528:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
if (ret)
^~

Right, gonna fix these warnings in the next version of the patch.
Thanks

vim +/for +526 drivers/reset/core.c

510 /**
511 * reset_control_array_deassert: deassert a list of resets
512 *
513 * @resets: reset control array holding info about a list of resets
514 * @num_rsts: number of resets to be deasserted.
515 *
516 * Returns 0 on success or error number on failure.
517 */
518 int reset_control_array_deassert(int num_rsts,
519 struct reset_control_array *resets)
520 {
521 int ret, i;
522
523 if (WARN_ON(IS_ERR_OR_NULL(resets)))
524 return -EINVAL;
525
> 526 for (i = 0; i < num_rsts; i++)
527 ret = reset_control_deassert(resets[i].rst);
528 if (ret)
529 goto err;
530
531 return 0;
532
533 err:
534 while (--i >= 0)

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

BRs
Vivek

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project