Re: [PATCH v4 02/11] VAS: Define macros, register fields and structures

From: Sukadev Bhattiprolu
Date: Tue Apr 04 2017 - 13:17:43 EST


Sukadev Bhattiprolu [sukadevatlinux.vnet.ibm.com] wrote:
> Define macros for the VAS hardware registers and bit-fields as well
> as couple of data structures needed by the VAS driver.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>

<snip>

> +++ b/arch/powerpc/platforms/powernv/vas.h
> @@ -0,0 +1,387 @@
> +/*
> + * Copyright 2016 IBM Corp.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
> +
> +#ifndef _VAS_H
> +#define _VAS_H
> +#include <linux/atomic.h>
> +#include <linux/idr.h>
> +#include <asm/vas.h>
> +
> +#ifdef CONFIG_PPC_4K_PAGES
> +# error "TODO: Compute RMA/Paste-address for 4K pages."
> +#else
> +#ifndef CONFIG_PPC_64K_PAGES
> +# error "Unexpected Page size."
> +#endif
> +#endif

The above "#error" breaks kbuild with some config. Here is the updated
patch with the block removed. Instead, [PATCH 4] now includes a "depends
on PPC_64K_PAGES".

Thanks,

Sukadev
----