RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

Hi Ritesh,
	I do not have the environment so should not have a try but I think Srinivas's patch should be Ok for your platform.
Please have a try.

Thanks a lot!


BR
Song Hongyan

-----Original Message-----
From: Ritesh Raj Sarraf [mailto:rrs@xxxxxxxxxxxxxx] 
Sent: Tuesday, April 4, 2017 3:14 AM
To: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>; Song, Hongyan <hongyan.song@xxxxxxxxx>; linux-iio <linux-iio@xxxxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Adding Stable, LKML and IIO MLs.

Hello Hongyan,

Do you have any feedback ? With the bisected commit reverted, I've been successfully running the machine without any issues.

Ritesh


On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> Hello Hongyan,
> 
> Can you check the findings of Ritesh?
> 
> Thanks,
> Srinivas
> 
> On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > Hello Srinivas,
> > 
> > With the Linux 4.10.7 release, I have encountered a regression 
> > introduced on my Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > 
> > 
> > rrs@learner:~$ lsusb
> > Bus 001 Device 002: ID 8087:8000 Intel Corp. Bus 001 Device 001: ID 
> > 1d6b:0002 Linux Foundation 2.0 root hub Bus 003 Device 001: ID 
> > 1d6b:0003 Linux Foundation 3.0 root hub Bus 002 Device 006: ID 
> > 048d:8350 Integrated Technology Express, Inc.
> > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. Bus 002 
> > Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd Bus 002 Device 
> > 003: ID 04f3:0303 Elan Microelectronics Corp.
> > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129 
> > Card Reader Controller Bus 002 Device 001: ID 1d6b:0002 Linux 
> > Foundation 2.0 root hub
> > 2017-04-01 / 14:04:49 âââÂÂâ
> > 
> > 
> > The ITE sensors do not feed any data on the 4.10.7 kernel. Reverting
> > back to
> > 4.10.5, everything works back.
> > 
> > 
> > After a git bisect, the culprit reported is:
> > 
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-trigger:
> > Change get
> > poll value function order to avoid sensor properties losing after
> > resume from S3
> > 1
> > 
> > Can you please review my findings to confirm that it really is a
> > regression bug
> > ?
> > 
> > 
> > Thanks,
> > Ritesh
> > 
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."