Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata()

From: Bart Van Assche
Date: Wed Apr 05 2017 - 11:10:59 EST


On Wed, 2017-04-05 at 15:55 +0200, SF Markus Elfring wrote:
> - size = sizeof(struct ib_cc_congestion_setting_attr);
> - ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL);
> + ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd
> + ->congestion_entries_shadow),
> + GFP_KERNEL);

The way how the above line has been split looks really weird. Please
move the entire kzalloc() call to the next line such that "*ppd" and
"->congestion_entries_shadow" appear on the same line.

Thanks,

Bart.