Re: [PATCH] sched: Fix numabalancing to work with isolated cpus

From: Mike Galbraith
Date: Thu Apr 06 2017 - 03:37:41 EST


On Tue, 2017-04-04 at 22:57 +0530, Srikar Dronamraju wrote:

> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f045a35..f853dc0 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1666,6 +1666,10 @@ static void task_numa_find_cpu(struct task_numa_env *env,
> > > > if (!cpumask_test_cpu(cpu, &env->p->cpus_allowed))
> > > > > continue;
>
> +> > > /* Skip isolated cpus */
> +> > > if (cpumask_test_cpu(cpu, cpu_isolated_map))
> +> > > > continue;

Methinks that should check for !cpu_rq(cpu)->sd, so the thing doesn't
screw up cpuset isolation either.

-Mike