Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303

[Juergen Borleis]

Hi Andrew,

On Wednesday 05 April 2017 20:12:32 Andrew Lunn wrote:
> [...]
> >  drivers/net/phy/lan9303-core.c | 924 +++++++++++++++++++++++++++++++++++++++++
> >  drivers/net/phy/lan9303.h      |  21 +
>
> drivers/net/dsa please.

Done in v2.

> One general comment. I'm assuming parts of this code comes from
> openwrt swconfig. In swconfig, i think they consider switches to be
> part of the PHY layer. In DSA, switches are switches, PHYs are
> PHYs. So the naming in this driver needs to reflect this.

And the LAN9303 is a switch with built-in PHYs :)

Juergen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |