Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

[jeffy]

Hi Andrzej,

On 04/06/2017 03:11 PM, Andrzej Hajda wrote:
> On 05.04.2017 10:29, Jeffy Chen wrote:
> > The dp aux is registered when binding analogix dp.
> >
> > Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
>
> Btw, if you are working already in this area you can check also to
> analogix_dp bind and unbind routines they looks suspiciously asymmetric.
> I guess component framework deals correctly with devm_* stuff but I see
> for example clk_prepare_enable not paired with clk_unprepare*.
ok, well do...
> --
> Regards
> Andrzej
> > ---
> >
> > Changes in v3: None
> > Changes in v2: None
> >
> >   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > index 28144a1..7b75f82 100644
> > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > @@ -1447,6 +1447,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
> >   			DRM_ERROR("failed to detach the panel\n");
> >   	}
> >
> > +	drm_dp_aux_unregister(&dp->aux);
> >   	pm_runtime_disable(dev);
> >   }
> >   EXPORT_SYMBOL_GPL(analogix_dp_unbind);