Re: [PATCH v3] pwm: rockchip: State of pwm clock should synchronize with pwm enabled state

From: Thierry Reding
Date: Thu Apr 06 2017 - 09:11:00 EST


On Wed, Mar 01, 2017 at 07:10:55PM +0800, David Wu wrote:
> From: "david.wu" <david.wu@xxxxxxxxxxxxxx>

You might want to set up git to use the correct author.

> If the pwm was not enabled at uboot loader, pwm could not work for clock
> always disabled at pwm driver. The pwm clock is enabled at beginning of
> pwm_apply(), but disabled at end of pwm_apply().
>
> If the pwm was enabled at uboot loader, pwm clock is always enabled unless
> closed by ATF. The pwm-backlight might turn off the power at early suspend,
> should disable pwm clock for saving power consume.
>
> It is important to provide opportunity to enable/disable clock at pwm driver,
> the pwm consumer should ensure correct order to call pwm enable/disable, and
> pwm driver ensure state of pwm clock synchronized with pwm enabled state.

Please always use all-caps for abbreviations suchs as "PWM". I've fixed
up the commit message and applied this to for-4.11/fixes.

Thanks,
Thierry

Attachment: signature.asc
Description: PGP signature