Re: [PATCH 0/6] mm: make movable onlining suck less
From: Michal Hocko
Date: Thu Apr 06 2017 - 11:41:43 EST
On Thu 06-04-17 10:24:49, Reza Arbab wrote:
> On Thu, Apr 06, 2017 at 03:08:46PM +0200, Michal Hocko wrote:
> >OK, so after recent change mostly driven by testing from Reza Arbab
> >(thanks again) I believe I am getting to a working state finally. All I
> >currently have is
> >in git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git tree
> >attempts/rewrite-mem_hotplug-WIP branch. I will highly appreciate more
> >testing of course and if there are no new issues found I will repost the
> >series for the review.
>
> Looking good! I can do my add/remove/repeat test and things seem fine.
>
> One thing--starting on the second iteration, I am seeing the WARN in
> free_area_init_node();
>
> add_memory
> add_memory_resource
> hotadd_new_pgdat
> free_area_init_node
> WARN_ON(pgdat->nr_zones || pgdat->kswapd_classzone_idx);
Have you tested with my attempts/rewrite-mem_hotplug-WIP mentioned
elsewhere? Because I suspect that "mm: get rid of zone_is_initialized"
might cause this.
--
Michal Hocko
SUSE Labs