Re: [PATCH -v6 05/13] futex: Change locking rules

From: Joe Perches
Date: Thu Apr 06 2017 - 11:58:50 EST


On Thu, 2017-04-06 at 14:28 +0200, Peter Zijlstra wrote:
> On Wed, Apr 05, 2017 at 02:18:43PM -0700, Darren Hart wrote:
> > On Wed, Mar 22, 2017 at 11:35:52AM +0100, Peter Zijlstra wrote:
> > > @@ -1336,6 +1418,7 @@ static int wake_futex_pi(u32 __user *uad
> > >
> > > if (cmpxchg_futex_value_locked(&curval, uaddr, uval, newval)) {
> > > ret = -EFAULT;
> > > +
> >
> > Stray whitespace addition? Not explicitly against coding-style, but I don't
> > normally see a new line before the closing brace leading to an else...
>
> I found it more readable that way. Sod checkpatch and co ;-)

The only good sod is the stuff you get to play games on.

And this week's best sod is Augusta's immaculate carpet
for the Masters Tournament.

So no worries from me. checkpatch is a brainless script.
Rules made to be broken, etc.

afaict another way to write that would be to use gotos
and that would be a lot more lines and less readable.