Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

[Andy Shevchenko]

On Thu, Apr 6, 2017 at 7:56 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
> On Thursday 06 April 2017 09:40 PM, Andy Shevchenko wrote:
>> On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx>
>> wrote:

>>> Adding different flag for the Open Drain/Open Source which is valid
>>> only when Single ended flag is enabled.
>>>          if (single_ended) {
>>> -               if (active_low)
>>> +               if (open_drain)
>>
>> This breaks ACPI case, right?

> In acpi case, single_ended is not handled. It only handles the active LOW.
>
> From code:

Fair enough.
I would look into ACPI spec for possibility to add this kind of functionality.

Thanks.

-- 
With Best Regards,
Andy Shevchenko