Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

From: Kirill A. Shutemov
Date: Thu Apr 06 2017 - 14:22:10 EST


On Thu, Apr 06, 2017 at 08:01:13PM +0200, Borislav Petkov wrote:
> On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote:
> > Config is attached.
>
> Thanks!
>
> > Looks like fake numa is the key.
>
> ...
>
> > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20 [ 0.000000] numa_register_memblks: numa_nodes_parsed: 0
> > numa_register_memblks: nid: 0
> > numa_register_memblks: nid: 1
> > numa_register_memblks: nid: 2
> > numa_register_memblks: nid: 3
>
> Yeah, the fake numa thing calls emu_setup_memblk() and that doesn't
> set numa_nodes_parsed to the number of fake numa nodes. And since with
> that "cleanup" which opened more work than it saved (btw, this is the
> last time I'm looking at crap like that) we got rid of the "enlarging"
> of the node mask to the actual nodes count and *that* blows up with
> numa_nodes_parsed having only node 0 in there.
>
> Long story short, something as trivial as this helps here:

Yep. Works for me.

Reported-and-tested-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

--
Kirill A. Shutemov