Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning

From: Jakub Kicinski
Date: Thu Apr 06 2017 - 19:15:52 EST


On Thu, 6 Apr 2017 13:54:35 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> On the case where nn->eth_port is null the warning message
> is printing the port by dereferencing this null pointer.
> Remove the deference to avoid a crash when printing the
> warning message.
>
> Detected by CoverityScan, CID#1426198 ("Dereference after null check")
>
> Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>

Thanks!