Re: [PATCH v3] regulator: Add driver for voltage controlled regulators

[Matthias Kaehlcke]

Hi Mark,

Thanks for the review!

El Thu, Apr 06, 2017 at 07:21:36PM +0100 Mark Brown ha dit:

> On Fri, Mar 31, 2017 at 01:50:35PM -0700, Matthias Kaehlcke wrote:
> 
> > +- compatible		  : must be "vctrl-regulator".
> > +- regulator-min-microvolt : smallest voltage consumers may set
> > +- regulator-max-microvolt : largest voltage consumers may set
> > +- ctrl-regulator:	  : the name of the regulator supplying the control
> > +			    voltage.
> 
> This looks good except for this bit where we read the regulator name out
> of the DT, that's generally a sign of bad practice for things that are
> less simple passives than things like this or fixed voltage regulators.
> As with the supplies for fixed voltage regulators just pick a name for
> the supply (ctrl seems fine to me) and use that, neither option is
> perfect but at elast this less typing for everyone and it's consistent
> with what other similar things are already doing.

Sounds good, I will send out an updated version shortly.

Matthias