Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

[Liping Zhang]

2017-04-09 16:26 GMT+08:00 Jan Engelhardt <jengelh@xxxxxxx>:
>
> On Sunday 2017-04-09 05:42, Arushi Singhal wrote:
>>On Sun, Apr 9, 2017 at 1:44 AM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
>>      On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote:
>>      > On Saturday 2017-04-08 19:21, Arushi Singhal wrote:
>>      >
>>      > >Replace explicit NULL comparison with ! operator to simplify code.
>>      >
>>      > I still wouldn't do this, for the same reason as before. Comparing to
>>      > NULL explicitly more or less gave an extra guarantee that the other
>>      > operand was also a pointer.
>>
>>      Arushi, where does it say in the coding style that this is prefered?
>>
>>This is reported by checkpatch.pl script.
>
> checkpatch has been controversial at times, like when people took the 80
> character limit way too literally. Changing pointer comparisons looks like
> another thing that is better left ignored.

Yes, I agree too. Converting the "if (p != NULL)" to "if (p)" like this seems
unnecessary.