Re: [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master

From: Christopher Bostic
Date: Sun Apr 09 2017 - 17:06:10 EST




On 4/5/17 11:35 AM, Randy Dunlap wrote:
On 04/04/17 19:06, Christopher Bostic wrote:
From: Chris Bostic <cbostic@xxxxxxxxxxxxxxxxxx>

Implement a FSI master using GPIO. Will generate FSI protocol for
read and write commands to particular addresses. Sends master command
and waits for and decodes a slave response.

Includes changes from Edward A. James <eajames@xxxxxxxxxx> and Jeremy
Kerr <jk@xxxxxxxxxx>.

Signed-off-by: Edward A. James <eajames@xxxxxxxxxx>
Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxx>
Signed-off-by: Chris Bostic <cbostic@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
---
drivers/fsi/Kconfig | 11 +
drivers/fsi/Makefile | 1 +
drivers/fsi/fsi-master-gpio.c | 610 ++++++++++++++++++++++++++++++++++++++++++
3 files changed, 622 insertions(+)
create mode 100644 drivers/fsi/fsi-master-gpio.c

diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
index 04c1a0e..9cf8345 100644
--- a/drivers/fsi/Kconfig
+++ b/drivers/fsi/Kconfig
@@ -9,4 +9,15 @@ config FSI
---help---
FSI - the FRU Support Interface - is a simple bus for low-level
access to POWER-based hardware.
+
+if FSI
+
+config FSI_MASTER_GPIO
+ tristate "GPIO-based FSI master"
+ depends on FSI && GPIOLIB
depends on FSI is redundant since "if FSI" does the same thing.

Hi Randy,
Thanks for the feedback, will correct.

-Chris
+ ---help---
+ This option enables a FSI master driver using GPIO lines.
+
+endif
+