Re: [PATCH v5 22/23] drivers/fsi: Add hub master support

[Christopher Bostic]

On 4/5/17 11:36 AM, Randy Dunlap wrote:
> On 04/04/17 19:06, Christopher Bostic wrote:
> > From: Chris Bostic <cbostic@xxxxxxxxxxxxxxxxxx>
> >
> > Add an engine driver to expose a "hub" FSI master - which has a set of
> > control registers in the engine address space, and uses a chunk of the
> > slave address space for actual FSI communication.
> >
> > Additional changes from Jeremy Kerr <jk@xxxxxxxxxx>.
> >
> > Signed-off-by: Chris Bostic <cbostic@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Jeremy Kerr <jk@xxxxxxxxxx>
> > Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> > ---
> >   drivers/fsi/Kconfig          |   9 ++
> >   drivers/fsi/Makefile         |   1 +
> >   drivers/fsi/fsi-master-hub.c | 327 +++++++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 337 insertions(+)
> >   create mode 100644 drivers/fsi/fsi-master-hub.c
> >
> > diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
> > index 0fa265c..e1156b4 100644
> > --- a/drivers/fsi/Kconfig
> > +++ b/drivers/fsi/Kconfig
> > @@ -18,6 +18,15 @@ config FSI_MASTER_GPIO
> >   	---help---
> >   	This option enables a FSI master driver using GPIO lines.
> >   
> > +config FSI_MASTER_HUB
> > +	tristate "FSI hub master"
> > +	depends on FSI
> redundant again.

Will correct.

Thanks,
Chris
> > +	---help---
> > +	This option enables a FSI hub master driver.  Hub is a type of FSI
> > +	master that is connected to the upstream master via a slave.  Hubs
> > +	allow chaining of FSI links to an arbitrary depth.  This allows for
> > +	a high target device fanout.
> > +
> >   config FSI_SCOM
> >   	tristate "SCOM FSI client device driver"
> >   	depends on FSI