On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) wrote:
> According to checkpatch.pl, comedi_lrange should be declared as `const
> struct` instead of `struct` in driver/staging/comedidev.h
>
> Signed-off-by: Arthur Brainville (Ybalrid) <ybalrid@xxxxxxxxxxxx>
> ---
> drivers/staging/comedi/comedidev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1bb9986f865e..82df090783b5 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;
> * There may also be a flag that indicates the minimum and maximum are merely
> * scale factors for an unknown, external reference.
> */
> -struct comedi_lrange {
> +const struct comedi_lrange {
> int length;
> struct comedi_krange range[];
> };
Huh? Please explain how this change is correct.
greg k-h
WARNING: struct comedi_lrange should normally be const
#626: FILE: drivers/staging/comedi/comedidev.h:626:
+struct comedi_lrange {
total: 0 errors, 1 warnings, 6 checks, 1043 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or
--fix-inplace.
In file included from drivers/staging/comedi//comedi_usb.h:24:0,
from drivers/staging/comedi//comedi_usb.c:21:
drivers/staging/comedi//comedidev.h:629:1: warning:
useless type qualifier in empty declaration
};