Re: [PATCH v3] ia64: fix module loading for gcc-5.4+

[Sergei Trofimovich]

On Mon, 10 Apr 2017 19:23:28 +0200
SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:

> > -	if (slot(insn) != 2) {
> > +	if (slot(insn) != 1 && slot(insn) != 2) {  
> 
> +	int const s = slot(insn);
> +	if (s < 1 || s > 2) {
> 
> Do run time characteristics matter for such a condition check here?

It's done once at kernel module load time. My guess would be
"not critical at all".

slot() is a pure arithmetic static inline function. You can compare
assembly output before and after your change.

You can measure the difference yourself using 'ski' emulator.
That's for example how I debugged and tested the patch:
     http://trofi.github.io/posts/199-ia64-machine-emulation.html

-- 

  Sergei

Attachment: pgpTgYYwFQRiR.pgp
Description: Цифровая подпись OpenPGP