Re: [PATCH -v2 0/9] mm: make movable onlining suck less
From: Igor Mammedov
Date: Tue Apr 11 2017 - 05:53:49 EST
On Tue, 11 Apr 2017 10:41:42 +0200
Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> On Tue 11-04-17 10:01:52, Igor Mammedov wrote:
> > On Mon, 10 Apr 2017 16:56:39 +0200
> > Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> [...]
> > > > #echo online_kernel > memory32/state
> > > > write error: Invalid argument
> > > > // that's not what's expected
> > >
> > > this is proper behavior with the current implementation. Does anything
> > > depend on the zone reusing?
> > if we didn't have zone imbalance issue in design,
> > the it wouldn't matter but as it stands it's not
> > minore issue.
> >
> > Consider following,
> > one hotplugs some memory and onlines it as movable,
> > then one needs to hotplug some more but to do so
> > one one needs more memory from zone NORMAL and to keep
> > zone balance some memory in MOVABLE should be reonlined
> > as NORMAL
>
> Is this something that we absolutely have to have right _now_? Or are you
> OK if I address this in follow up series? Because it will make the
> current code slightly more complex and to be honest I would rather like
> to see this "core" merge and build more on top.
It's fine by me to do it on top.