Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111

[Eric Anholt]

Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx> writes:

> On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote:
>> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx> writes:
>> 
>> > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote:
>> >> v5: Move register definitions inside the driver directory, fix build
>> >>     in COMPILE_TEST and !AMBA mode.
>> >
>> > Why is it necessary to move the register definitions there, when
>> > they're already available in linux/amba/clcd.h and are required
>> > for the FB driver?
>> >
>> > It is absurd to have driver specific register definitions.
>> 
>> Because after v2, v3, and v4, I still didn't have an ack on the patch to
>> move the register definitions from linux/amba/clcd.h to
>> linux/amba/clcd-reg.h.  If you'd like to go back and ack that, I'd reuse
>> them.
>
> I don't remember seeing such a patch, sorry.

https://patchwork.kernel.org/patch/9654991/

Attachment: signature.asc
Description: PGP signature