Re: [PATCH v3] HID: asus: support backlight on USB keyboards

[Carlo Caione]

On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires
<benjamin.tissoires@xxxxxxxxxx> wrote:
> On Apr 06 2017 or thereabouts, Carlo Caione wrote:

>> +     ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> +     if (ret < 0) {
>> +             /* No need to have this still around */
>> +             devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> +             cancel_work_sync(&drvdata->kbd_backlight->work);
>
> Small nitpick, you don't need to call cancel_work_sync() here, nobody
> could have called a worker. But OTOH, it doesn't hurt.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Thanks Benjamin. Who should pick this up?

-- 
Carlo Caione  |  +39.340.80.30.096  |  Endless