Re: [kbuild-all] [PATCH V2 16/16] block, bfq: split bfq-iosched.c into multiple source files

From: Paolo Valente
Date: Wed Apr 12 2017 - 05:24:29 EST



> Il giorno 12 apr 2017, alle ore 10:39, Ye Xiaolong <xiaolong.ye@xxxxxxxxx> ha scritto:
>
> On 04/11, Paolo Valente wrote:
>>
>>> Il giorno 02 apr 2017, alle ore 12:02, kbuild test robot <lkp@xxxxxxxxx> ha scritto:
>>>
>>> Hi Paolo,
>>>
>>> [auto build test ERROR on block/for-next]
>>> [also build test ERROR on v4.11-rc4 next-20170331]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>
>> Hi,
>> this seems to be a false positive. Build is correct with the tested
>> tree and the .config.
>>
>
> Hmm, this error is reproducible in 0day side, and you patches were applied on
> top of 803e16d "Merge branch 'for-4.12/block' into for-next", is it the same as
> yours?
>

I have downloaded the offending tree directly from the github page.

Here are my steps in super detail.

I followed the url: https://github.com/0day-ci/linux/commits/Paolo-Valente/block-bfq-introduce-the-BFQ-v0-I-O-scheduler-as-an-extra-scheduler/20170402-100622
and downloaded the tree ("Browse the repository at this point in
history" link on the top commit, then "Download ZIP"), plus the
.config.gz attached to the email.

Then I built with no error.

To try to help understand where the mistake is, the compilation of the
files of course fails because each of the offending files does not
contain the definition of the reported functions. But that definition
is contained in one of the other files for the same module. I mean
one of the files listed in the following rule in block/Makefile:
obj-$(CONFIG_IOSCHED_BFQ) += bfq-iosched.o bfq-wf2q.o bfq-cgroup.o

Maybe I'm making some mistake in the Makefile, or I forgot to modify
some other configuration file?

Help! :)

Thanks,
Paolo

> Thanks,
> Xiaolong
>
>> Thanks,
>> Paolo
>>
>>> url: https://github.com/0day-ci/linux/commits/Paolo-Valente/block-bfq-introduce-the-BFQ-v0-I-O-scheduler-as-an-extra-scheduler/20170402-100622
>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
>>> config: i386-allmodconfig (attached as .config)
>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>>> reproduce:
>>> # save the attached .config to linux build tree
>>> make ARCH=i386
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>>> ERROR: "bfq_mark_bfqq_busy" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfqg_stats_update_dequeue" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_clear_bfqq_busy" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_clear_bfqq_non_blocking_wait_rq" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_bfqq_non_blocking_wait_rq" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_clear_bfqq_wait_request" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_timeout" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfqg_stats_set_start_empty_time" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_weights_tree_add" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_put_queue" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_bfqq_sync" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfqg_to_blkg" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfqq_group" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_weights_tree_remove" [block/bfq-wf2q.ko] undefined!
>>>>> ERROR: "bfq_bic_update_cgroup" [block/bfq-iosched.ko] undefined!
>>>>> ERROR: "bfqg_stats_set_start_idle_time" [block/bfq-iosched.ko] undefined!
>>>>> ERROR: "bfqg_stats_update_completion" [block/bfq-iosched.ko] undefined!
>>>>> ERROR: "bfq_bfqq_move" [block/bfq-iosched.ko] undefined!
>>>>> ERROR: "bfqg_put" [block/bfq-iosched.ko] undefined!
>>>>> ERROR: "next_queue_may_preempt" [block/bfq-iosched.ko] undefined!
>>>
>>> ---
>>> 0-DAY kernel test infrastructure Open Source Technology Center
>>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>> <.config.gz>
>>
>> _______________________________________________
>> kbuild-all mailing list
>> kbuild-all@xxxxxxxxxxxx
>> https://lists.01.org/mailman/listinfo/kbuild-all